libxl: do not attempt to write "shutdown" dm-command
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 20 Jan 2011 16:32:33 +0000 (16:32 +0000)
committerIan Jackson <ian.jackson@eu.citrix.com>
Thu, 20 Jan 2011 16:32:33 +0000 (16:32 +0000)
commit1da4ffed6fc715d2593f96925ecb98773b1de8df
tree937381b2d9d1f34c6e8b0870577c627ebe483f0f
parent18bb4ab9daa52b4c99906c4c35e18695a1f3c14d
libxl: do not attempt to write "shutdown" dm-command

libxl_domain_destroy writes the command "shutdown" to the xenstore
node with which it communicates with qemu.  However:
 - qemu does not understand this command and ignores it (printing a
   message)
 - libxl doesn't wait for the answer and immediately pauses the domain
   anyway
 - destroy is the ungraceful (force) operation and should not
   negotiate with qemu anyway
 - even in the graceful shutdown case, there would actually be nothing
   that qemu needs to do.

Under some circumstances, this entry in xenstore will survive the
domain's death, ie be leaked.

So remove the erroneous code.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl.c